Re: PATCH: Table header size

Поиск
Список
Период
Сортировка
От Chethana Kumar
Тема Re: PATCH: Table header size
Дата
Msg-id CAH4-4WvsYiXdiTPPY3WP6QzFHmaHrn8sa1VNbDY_ouY9L3oemA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: PATCH: Table header size  (Dave Page <dpage@pgadmin.org>)
Ответы Re: PATCH: Table header size  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Список pgadmin-hackers
Yes Dave, I am agree with you!

But some default padding is required for left and right.
For example- 8px 5px 8px 5px; (top, right, bottom, left) 
This combination will get you similar look and feel of output same as my reference design.

current_rev_2x.png

---
Chethana kumar

On Fri, Feb 8, 2019 at 2:56 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

Can we adjust the top/bottom padding, but leave the left/right? By modifying the left/right padding, we cause the data to become offset with the header.

Otherwise I'm cool with the change.

On Fri, Feb 8, 2019 at 6:40 AM Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:
Hi Dave/Team,

Just explain it -

Change - Increased the padding for 'th' (table header)

Reason - The table header is not getting highlighted enough thus the sense of hierarchy and visual difference between 'th' and 'td' is not strong enough

Case study -
If you see the existing version of table everything looks flat in terms of hierarchy due to 'white background' for both 'th' and 'td' except the header texts are in bold.
I would recommend you to see it in the actual application for better clarity of the issue.

Conclusion -
Padding does that required differentiation part in order to highlight/achieve the hierarchy.

Attaching the reference design too and going further I am aiming to reach this level of look and feel with our application.
I really feel that "a good amount of breathing space sets the user's mind calm and focused towards reading the data" :)



---
Chethana kumar


On Fri, Feb 8, 2019 at 10:34 AM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave/Team,

As my offline conversation with Chethana, we need better look 'n' feel for the table header row.
And - as per his proposal I've modified the table header row to look different from rest of the rows.

Please find the attached patch for the same.

Let me share the screen shot for the now, and proposed change. 
Now:
Screen Shot 2019-02-08 at 10.31.35 AM.png

Proposed:
Screen Shot 2019-02-08 at 10.29.20 AM.png

Please let me know your thoughts.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation


The Postgres Database Company

P: +91 86981 57146


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation


The Postgres Database Company

P: +91 86981 57146
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Murtuza Zabuawala
Дата:
Сообщение: Re: [pgAdmin4[RM#3948] Fix backform note control style
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Add a script for auto-generating the library.txtfile