On Wed, Oct 20, 2021 at 8:27 PM Michael Paquier <michael@paquier.xyz> wrote:
> Perhaps. This means the creation of a new database with shared deps
> in contrib/amcheck/t/. But is amcheck really a correct target here?
> The fields involved here are an int, some OIDs and a char with a given
> subset of values making them harder to check. pg_catcheck does checks
> across catalogs, maintaining a mapping list as of its definitions.c.
Users should be able to use pg_amcheck as a high-level corruption
detection tool, which should include any new pg_catcheck style catalog
checking functionality. Whether or not we need to involve
contrib/amcheck itself doesn't seem important to me right now. Offhand
I think that we wouldn't, because as you point out pg_catcheck is a
frontend program that checks multiple databases.
--
Peter Geoghegan