Re: [PATCH] Fix memory corruption in pg_shdepend.c

On Wed, Oct 20, 2021 at 07:59:50PM -0700, Peter Geoghegan wrote:
> I think that EDB's pg_catcheck tool can detect problems like this one.

Yes, pg_catcheck is able to catch that.

> Perhaps it can be converted into an amcheck/pg_amcheck patch, and
> submitted. That would give us very broad coverage.

Perhaps.  This means the creation of a new database with shared deps
in contrib/amcheck/t/.  But is amcheck really a correct target here?
The fields involved here are an int, some OIDs and a char with a given
subset of values making them harder to check.  pg_catcheck does checks
across catalogs, maintaining a mapping list as of its definitions.c.
--
Michael