On Tue, Mar 12, 2019 at 10:27 AM Michael Paquier <michael@paquier.xyz> wrote:
On Mon, Mar 11, 2019 at 07:49:11PM +0800, Shaoqi Bai wrote: > Thanks, will work on it as you suggested > Add pg_basebackup --T olddir=newdir to support check the consistency of a > tablespace created before promotion > Add run_test('remote');
Thanks for considering my input. Why don't you register your patch to the next commit fest then so as it goes through a formal review once you are able to provide a new version? The commit fest is here: https://commitfest.postgresql.org/23/
We are currently in the process of wrapping up the last commit fest for v12, so this stuff will have to wait a bit :(
It could be an idea to split the patch in two pieces: - One patch which refactors the code for the new option in PostgresNode.pm - Second patch for the new test with integration in RewindTest.pm. This should touch different parts of the code, so combining both would be fine as well for me :)
Thanks for your advice, sorry for taking so long to give update in the thread, because I am stuck in modifing Perl script, knowing little about Perl language.
I tried to do the following two things in this patch.
1. add pg_basebackup --T olddir=newdir to support check the consistency of a tablespace created before promotion
2. run both run_test('local') and run_test('remote');
The code can pass make installcheck under src/bin/pg_rewind, but can not pass make installcheck under src/bin/pg_basebackup.
Because the patch refactor is not done well.
The patch still need refactor, to make other tests pass, like tests under src/bin/pg_basebackup.
Sending the letter is just to let you know the little progress on the thread.