Re: [PATCH] fix newly added server being lost when crashing

Поиск
Список
Период
Сортировка
От Ashesh Vashi
Тема Re: [PATCH] fix newly added server being lost when crashing
Дата
Msg-id CAG7mmoyfRG9v8VKqHhBXw=Wy-MzHEqRKHZ8QKPG6TGw3GBbf=w@mail.gmail.com
обсуждение исходный текст
Ответ на [PATCH] fix newly added server being lost when crashing  (Kaarel Moppel <kaarel.moppel@gmail.com>)
Ответы Re: [PATCH] fix newly added server being lost when crashing
Список pgadmin-hackers
Дерево обсуждения
Hi Kaarel,

I think - everything looks good except:
1. Please use TAB instead of 4 spaces
2. You don't require to define Flush function after inheriting the wxConfig class publicly.
     Or,
    Define it only if you keep the wxConfig inherited protectively.


On Mon, Jan 6, 2014 at 3:48 AM, Kaarel Moppel <kaarel.moppel@gmail.com> wrote:
Hi,

Sending some 3 small fixes in separate emails for issues that me and my colleagues found really annoying. This is my first try at Pgadmin and I haven't done too much C++ though so in case something should be corrected let me know and I'd be happy to do that.

Cheers,
Kaarel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Ashesh Vashi
Дата:
Сообщение: Re: [PATCH] fix newly added server being lost when crashing
Следующее
От: "J.F. Oster"
Дата:
Сообщение: Re: PATCH: Improve status bar in Edit Data window