Re: [PATCH] fix newly added server being lost when crashing

Поиск
Список
Период
Сортировка
От Kaarel Moppel
Тема Re: [PATCH] fix newly added server being lost when crashing
Дата
Msg-id CA+gt1FfY8_YMFkD5=aooTLoZv2s4=S7sGVeDp_=zO7o2UKTjmg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] fix newly added server being lost when crashing  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Ответы Re: [PATCH] fix newly added server being lost when crashing
Список pgadmin-hackers
Ok, got it. Corrected version in attach now.


On Mon, Jan 6, 2014 at 12:29 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Kaarel,

I think - everything looks good except:
1. Please use TAB instead of 4 spaces
2. You don't require to define Flush function after inheriting the wxConfig class publicly.
     Or,
    Define it only if you keep the wxConfig inherited protectively.


On Mon, Jan 6, 2014 at 3:48 AM, Kaarel Moppel <kaarel.moppel@gmail.com> wrote:
Hi,

Sending some 3 small fixes in separate emails for issues that me and my colleagues found really annoying. This is my first try at Pgadmin and I haven't done too much C++ though so in case something should be corrected let me know and I'd be happy to do that.

Cheers,
Kaarel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi


Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Kaarel Moppel
Дата:
Сообщение: Re: [PATCH] Added a menu option to disable code folding
Следующее
От: Ashesh Vashi
Дата:
Сообщение: Re: [PATCH] fix newly added server being lost when crashing