Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

Поиск
Список
Период
Сортировка
От Rosser Schwarz
Тема Re: [HACKERS] Patch: add --if-exists to pg_recvlogical
Дата
Msg-id CAFnxYwiOqt_5ke3y1RCEWxchQS_kW8Nd3XtSMJjOSi6ZinR5NA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] Patch: add --if-exists to pg_recvlogical  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Ответы Re: [HACKERS] Patch: add --if-exists to pg_recvlogical  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Список pgsql-hackers
On Fri, Sep 1, 2017 at 10:22 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
> I understand the --drop-slot part.  But I don't understand what it means
> to ignore a missing replication slot when running --start.

I'm not sure I do either, honestly. I followed the Principle of Least Surprise in making it a no-op when those switches are used and the slot doesn't exist, over "no one will ever do that". Because someone will.

I'm happy to hear suggestions on what to do in that case beyond exit cleanly.

> The same option should be added to pg_receivewal as well.

Done. 

On Fri, Sep 8, 2017 at 21:06 Thomas Munro <thomas.munro@enterprisedb.com> wrote:
> Also "<option>--start<option>" breaks the documentation build
> (missing slash on the closing tag).

Fixed, thanks. 

Please see revised patch, attached, addressing both comments.

rls

--
:wq
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: [HACKERS] SQL/JSON in PostgreSQL
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] [PATCH] Generic type subscripting