Re: Use %u to print user mapping's umid and userid

Поиск
Список
Период
Сортировка
От Ashutosh Bapat
Тема Re: Use %u to print user mapping's umid and userid
Дата
Msg-id CAFjFpRdeWAs9rypTkKr3_K3vas39oH4OMo8aYO2DrF0aGosuOw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Use %u to print user mapping's umid and userid  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Ответы Re: Use %u to print user mapping's umid and userid  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Список pgsql-hackers


On Wed, May 11, 2016 at 1:10 PM, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> wrote:
On 2016/05/10 16:56, Etsuro Fujita wrote:
Here is a patch to fix this.

I found that the previous patch handles the ForeignScan's fs_relids Bitmapset destructively.  Also, I noticed that I removed some existing comments inadvertently.  So, I'm attaching the updated patch to fix those things.  I'll add this to the next CF.  I think this should be addressed in advance of the release of 9.6, though.


The patch is calculating user mapping when it's readily available through RelOptInfo::fdw_private. That incurs a catalog lookup unnecessarily. Instead, can we add new function makeOid, oidVal on the lines of makeInteger and intVal to store and retrieve an OID resp. and also corresponding print function? It might be helpful in future.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Etsuro Fujita
Дата:
Сообщение: Re: Odd oid-system-column handling in postgres_fdw
Следующее
От: Etsuro Fujita
Дата:
Сообщение: Re: Use %u to print user mapping's umid and userid