Re: patch: make_timestamp function

Поиск
Список
Период
Сортировка
От Pavel Stehule
Тема Re: patch: make_timestamp function
Дата
Msg-id CAFj8pRBZA2Vp=kmf5u4As5wr=7O5=j5tSa=csDg0+QEVEuToFg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: patch: make_timestamp function  (Pavel Stehule <pavel.stehule@gmail.com>)
Список pgsql-hackers
Hello

updated patch

time zone type functions are overloaded now

postgres=# select '1973-07-15 08:15:55.33+02'::timestamptz;
        timestamptz       
---------------------------
 1973-07-15 07:15:55.33+01
(1 row)

postgres=# SELECT make_timestamptz(1973, 07, 15, 08, 15, 55.33, 2);
     make_timestamptz     
---------------------------
 1973-07-15 07:15:55.33+01
(1 row)

postgres=# SELECT make_timestamptz(1973, 07, 15, 08, 15, 55.33);
     make_timestamptz     
---------------------------
 1973-07-15 08:15:55.33+01
(1 row)

Regards

Pavel




2013/12/15 Pavel Stehule <pavel.stehule@gmail.com>
Hello


2013/12/13 Jim Nasby <jim@nasby.net>
On 12/13/13 1:49 PM, Fabrízio de Royes Mello wrote:

On Fri, Dec 13, 2013 at 5:35 PM, Tom Lane <tgl@sss.pgh.pa.us <mailto:tgl@sss.pgh.pa.us>> wrote:

 >
 > Fabrízio de Royes Mello <fabriziomello@gmail.com <mailto:fabriziomello@gmail.com>> writes:
 > > I think the goal of the "make_date/time/timestamp" function series is build
 > > a date/time/timestamp from scratch, so the use of 'make_timestamptz' is to
 > > build a specific timestamp with timezone and don't convert it.
 >
 > Yeah; we don't really want to incur an extra timezone rotation just to get
 > to a timestamptz.  However, it's not clear to me if make_timestamptz()
 > needs to have an explicit zone parameter or not.  It could just assume
 > that you meant the active timezone.
 >

+1. And if you want a different timezone you can just set the 'timezone' GUC.

Why wouldn't we have a version that optionally accepts the timezone? That mirrors what you can currently do with a cast from text, and having to set the GUC if you need a different TZ would be a real PITA.

It is not bad idea.

What will be format for timezone in this case? Is a doble enough?

last version of this patch attached (without overloading in this moment)


 
--
Jim C. Nasby, Data Architect                       jim@nasby.net
512.569.9461 (cell)                         http://jim.nasby.net


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Christian Kruse
Дата:
Сообщение: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication
Следующее
От: Kevin Grittner
Дата:
Сообщение: Re: pg_rewarm status