2015-07-21 9:53 GMT+02:00 Heikki Linnakangas <hlinnaka@iki.fi>:
On 07/21/2015 10:38 AM, Pavel Stehule wrote:
where we are with this patch? Can I do some for it?
I still feel this approach is misguided, and we should be tweaking psql and/or libpq instead. I don't feel strongly though, and if some other committer wants to pick this up in its current form, I won't object. So this patch has reached an impasse, and if no-one else wants to pick this up, I'm going to mark this as "Returned with Feedback" and move on.
Can we define, when we have a agreement and where not? The missing context for RAISE EXCEPTION statement is a important issue and I would to solve it.
last patch has two parts:
1. remove plpgsql fix, that remove context for plpgsql RAISE statement - it is working good enough for less NOTICE level, and work badly for EXCEPTION and higher level.
2. enforce filtering of CONTEXT field on both sides (client/log)
For me, @1 is important and good solution (because there is strange inconsistency between PLpgSQL and any other PL), @2 allows more ways - but probably log_min_context (WARNING) is good idea too.
The advantage of context filtering on server side (client_min_message) is one - it can be controlled by plpgsql - so I can do dynamic decision if some NOTICE will have context or not.
The complexity will be +/- same for psql/libpq or for server side filtering.