Re: [GSoC][Patch] Automatic Mode Detection V1

Поиск
Список
Период
Сортировка
От Yosry Muhammad
Тема Re: [GSoC][Patch] Automatic Mode Detection V1
Дата
Msg-id CAFSMqn_n4kMF-BYHj7mVpR1oe5-ztZHV+XjVcM5Bc-Tj=srSBA@mail.gmail.com
обсуждение исходный текст
Ответ на [GSoC][Patch] Automatic Mode Detection V1  (Yosry Muhammad <yosrym93@gmail.com>)
Ответы Re: [GSoC][Patch] Automatic Mode Detection V1  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
This is a patch fixing a problem with the above patch that happened when:
- primary key columns are renamed.
- other columns are renamed to be like primary key columns.

This problem happened mainly because the primary keys are identified in the front-end by their names. This can be handled in a better way in a future update where columns that are primary keys are identified by the backend and sent to the frontend instead.
Also, renamed columns can be handled better by making them read-only in a future update (now they are editable but they cannot be updated as a column with the new name does not exist - it produces an error message to the user).

Waiting for your feedback. Thanks !

On Sat, Jun 15, 2019 at 8:48 AM Yosry Muhammad <yosrym93@gmail.com> wrote:
Dear all,

This is my first patch of my GSoC project, query tool automatic mode detection.

In this patch, the initial (basic) version of the project is implemented. In this version, query resultsets are updatable if and only if:
- All the columns belong to a single table
- No duplicate columns are available
- All the primary keys of the table are available

Inserts, updates and deletes work automatically when the resultset is updatable.

The 'save' button in the query tool works automatically to save the changes in the resultset if the query is the updatable, and saves the query to a file otherwise. The 'save as' button stays as is.

I will work on improving and adding features to this version throughout my work during the summer according to what has the highest priorities (supporting duplicate columns or columns produced by functions or aggregations as read-only columns in the results seems like a good next move).

Please give me your feedback of the changes I made, and any hints or comments that will improve my code in any aspect.

I also have a couple of questions,
- Should the save button in the query tool work the way I am using it now? or should there be a new dedicated button for saving the query to a file?

- What documentations or unit tests should I write? any guidelines here would be appreciated.

Thanks a lot!


--
Yosry Muhammad Yosry

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.


--
Yosry Muhammad Yosry

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Yosry Muhammad
Дата:
Сообщение: [GSoC][Patch] Automatic Mode Detection V1
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to testReverse Engineering SQL