Re: row filtering for logical replication

On Tue, Oct 12, 2021 at 1:33 PM Ajin Cherian <itsajin@gmail.com> wrote:
> > I do not like the fact that, first we have deformed the tuples and we
> > are again using the HeapTuple
> > for expression evaluation machinery and later the expression
> > evaluation we do the deform again.
> >
> > So why don't you use the deformed tuple as it is to store as a virtual tuple?
> >
> > Infact, if newtup_changed is true then you are forming back the tuple
> > just to get it deformed again
> > in the expression evaluation.
> >
> > I think I have already given this comment on the last version.
>
> Right, I only used the deformed tuple later when it was written to the
> stream. I will modify this as well.

I have made the change to use the virtual slot for expression
evaluation and avoided tuple deformation.

regards,
Ajin Cherian
Fujitsu Australia