Re: [pgAdmin4][Patch]: #3412 - Add support for PRIMARY KEY, FOREIGNKEY, indexes, and triggers on partitioned tables for PG 11

Hi Khushboo

Following are my initial review comments:

• Fix PEP-8 warnings.
• We should hide "Modulus" and "Remainder" columns for PG/EPAS 10 as Hash partition is not supported in that.
• Primary key switch control on "columns" tab should be enabled for partitioned table created on PG/EPAS 11.
• Please verify that Unique constraint are supported for PG/EPAS 11 or not. 

Will do code review tomorrow.

On Wed, Jul 25, 2018 at 4:29 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached patch for RM #3412.

- Add support for PRIMARY KEY, FOREIGN KEY, indexes, and triggers on partitioned tables for PG 11

- Add support for partitioning by  HASH key.

Thanks,

Khushboo

--

Akshay Joshi

Sr. Software Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246