Re: [pgAdmin4][Patch]: #3412 - Add support for PRIMARY KEY, FOREIGNKEY, indexes, and triggers on partitioned tables for PG 11

Поиск
Список
Период
Сортировка
От Khushboo Vashi
Тема Re: [pgAdmin4][Patch]: #3412 - Add support for PRIMARY KEY, FOREIGNKEY, indexes, and triggers on partitioned tables for PG 11
Дата
Msg-id CAFOhELe9LUXYAAmKPStOb04VBNeb03rykmFckZ4Ma=QC7M5dkg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch]: #3412 - Add support for PRIMARY KEY, FOREIGNKEY, indexes, and triggers on partitioned tables for PG 11  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: #3412 - Add support for PRIMARY KEY, FOREIGNKEY, indexes, and triggers on partitioned tables for PG 11  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
For more clarification, The comments given by Aditya are:

1. I did not understand the below highlighted code. As per my understanding, index on partitioned table will not be supported with this code. But, Postgres 11 supports indexes on partitioned table. Could you please add some comments in the code above the highlighted code.
-            if 'tid' in kwargs and manager.version >= 100000:
+            if 'tid' in kwargs and 100000 <= manager.version < 110000:
                 return not backend_supported(self, manager, **kwargs)


2.  And for precautionary purpose, I would suggest replacing double equals(==) with triple equals(===) wherever you've used. Example below.

+      editable: function(m) {

+        if(m.handler && m.handler.top &&

+          m.handler.top.attributes &&

+          m.handler.top.attributes.partition_type == 'hash' &&



On Fri, Jul 27, 2018 at 2:27 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached updated patch with the fixes. I have also considered the suggestions given by Aditya on different email thread.

Thanks,
Khushboo


On Wed, Jul 25, 2018 at 6:01 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

Following are my initial review comments:
  • Fix PEP-8 warnings.
  • We should hide "Modulus" and "Remainder" columns for PG/EPAS 10 as Hash partition is not supported in that.
  • Primary key switch control on "columns" tab should be enabled for partitioned table created on PG/EPAS 11.
  • Please verify that Unique constraint are supported for PG/EPAS 11 or not. 
Will do code review tomorrow.

On Wed, Jul 25, 2018 at 4:29 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,


Please find the attached patch for RM #3412.

- Add support for PRIMARY KEY, FOREIGN KEY, indexes, and triggers on partitioned tables for PG 11

- Add support for partitioning by  HASH key.


Thanks,
Khushboo



--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: pgAdmin 4 Jenkins
Дата:
Сообщение: Jenkins build is back to normal : pgadmin4-master-python34 #701
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Add support for reset saved password. Fixes #3074