Re: [pgAdmin4][Patch]: RM #3511 Passwords not stored for ssh tunnel connections

Поиск
Список
Период
Сортировка
От Khushboo Vashi
Тема Re: [pgAdmin4][Patch]: RM #3511 Passwords not stored for ssh tunnel connections
Дата
Msg-id CAFOhELf8+f6ANZg5yvXE5jPWDPoe+fR4MUHq9Ai0UFU0sT_OmQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch]: RM #3511 Passwords not stored for ssh tunnel connections  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: RM #3511 Passwords not stored for ssh tunnel connections  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Akshay,

The functionality works properly.

Some minor comments as below:
- Migration file should contain the purpose of the file instead of empty message string.
- Please remove unwanted imports from the migration file.
- The success message should be 'The saved password cleared successfully.' or 'Cleared the saved password successfully.' 

Thanks,
Khushboo

On Fri, Aug 3, 2018 at 7:16 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers, 

As per discussion I have changed the menu string from "Reset SSH Tunnel Password" to "Clear SSH Tunnel Password". Apart from that I have updated the documentation also fixed size of some images for the documentation. 

Attached is the latest patch. Please review it.   

On Wed, Aug 1, 2018 at 2:50 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix RM #3511 Passwords not stored for ssh tunnel connections. Please review it.

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin4][RM2136] Include "?" on all routes that are loaded
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: pgAdmin4 should work with python 3.7, Fixes #3458