On Fri, Apr 1, 2022 at 4:43 AM Thomas Munro <thomas.munro@gmail.com> wrote:
>
> On Thu, Mar 31, 2022 at 11:09 PM John Naylor
> <john.naylor@enterprisedb.com> wrote:
> > In a couple days I'm going to commit the v3 patch "accelerate tuple
> > sorting for common types" as-is after giving it one more look, barring
> > objections.
Pushed.
> Hi John,
>
> Thanks so much for all the work you've done here! I feel bad that I
> lobbed so many experimental patches in here and then ran away due to
> lack of cycles. That particular patch (the one cfbot has been chewing
> on all this time) does indeed seem committable, despite the
> deficiencies/opportunities listed in comments. It's nice to reduce
> code duplication, it gives the right answers, and it goes faster.
Thanks for chiming in! It gives me more confidence that there wasn't
anything amiss that may have gone unnoticed. And no worries -- my own
review efforts here have been sporadic. ;-)
--
John Naylor
EDB: http://www.enterprisedb.com