On Mon, Jan 16, 2023 at 1:28 PM John Naylor <
john.naylor@enterprisedb.com> wrote:
>
>
> I wrote:
> > ...but arguably the earlier check is close enough that it's silly to assert in the "else" branch, and I'd be okay with just nuking those lines. Another thing that caught my attention is the assumption that unsetting a bit is so expensive that we have to first check if it's set, so we may as well remove "IS_BRACKET(Np->Num)" as well.
>
> The attached is what I mean. I'll commit this this week unless there are objections.
I've pushed this and the cosmetic fix in pg_dump. Those were the only things I saw that had some interest, so I closed the CF entry.
--
John Naylor
EDB:
http://www.enterprisedb.com