Re: Correct comment wording in extension.c
| От | albert tan |
|---|---|
| Тема | Re: Correct comment wording in extension.c |
| Дата | |
| Msg-id | CAEzortkOoNDpoQgqTFtCYsf6u_D5O39gqnDeFiV4V5JDTPEdyw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Correct comment wording in extension.c (John Naylor <johncnaylorls@gmail.com>) |
| Ответы |
回复: Correct comment wording in extension.c
|
| Список | pgsql-hackers |
>On Wed, Jan 7, 2026 at 1:13 PM albert tan <alterttan1223@gmail.com> wrote:
>> I believe:
>> 'will be searched' is better than 'will be search'.
>> 'it assumes' is better than 'it assume'.
>
>Those are indeed grammatical errors. From a quick eyeball scan, this
>file has other wording issues:
>
>/*
> * Ignore already-found names. They are not reachable by the
> * path search, so don't shown them.
> */
>
>"show"
>
>/*
> * The directory parameter can be omitted, absolute, or relative to the
> * installation's base directory, which can be the sharedir or a custom
> * path that it was set extension_control_path. It depends where the
> * .control file was found.
> */
>
>I imagine this means "or a custom path that was set via extension_control_path".
>
>/*
> * Return a list of directories declared on extension_control_path GUC.
> */
>I would guess this normally phrased something like "Return the list of
>directories in extension_control_path".
Hi Join,
Thanks for pointing out extra issues. I have addressed them in v2.
>> I believe:
>> 'will be searched' is better than 'will be search'.
>> 'it assumes' is better than 'it assume'.
>
>Those are indeed grammatical errors. From a quick eyeball scan, this
>file has other wording issues:
>
>/*
> * Ignore already-found names. They are not reachable by the
> * path search, so don't shown them.
> */
>
>"show"
>
>/*
> * The directory parameter can be omitted, absolute, or relative to the
> * installation's base directory, which can be the sharedir or a custom
> * path that it was set extension_control_path. It depends where the
> * .control file was found.
> */
>
>I imagine this means "or a custom path that was set via extension_control_path".
>
>/*
> * Return a list of directories declared on extension_control_path GUC.
> */
>I would guess this normally phrased something like "Return the list of
>directories in extension_control_path".
Hi Join,
Thanks for pointing out extra issues. I have addressed them in v2.
John Naylor <johncnaylorls@gmail.com> 于2026年1月7日周三 14:56写道:
On Wed, Jan 7, 2026 at 1:13 PM albert tan <alterttan1223@gmail.com> wrote:
> I believe:
> 'will be searched' is better than 'will be search'.
> 'it assumes' is better than 'it assume'.
Those are indeed grammatical errors. From a quick eyeball scan, this
file has other wording issues:
/*
* Ignore already-found names. They are not reachable by the
* path search, so don't shown them.
*/
"show"
/*
* The directory parameter can be omitted, absolute, or relative to the
* installation's base directory, which can be the sharedir or a custom
* path that it was set extension_control_path. It depends where the
* .control file was found.
*/
I imagine this means "or a custom path that was set via extension_control_path".
/*
* Return a list of directories declared on extension_control_path GUC.
*/
I would guess this normally phrased something like "Return the list of
directories in extension_control_path".
--
John Naylor
Amazon Web Services
Вложения
В списке pgsql-hackers по дате отправления: