Ranier Vilela писал 2021-08-19 14:01: > Em qui., 19 de ago. de 2021 às 07:50, Zhihong Yu <zyu@yugabyte.com> >> Hi, >> For 0001 patch: >> >> + if ((s->op != SVFOP_CURRENT_TIMESTAMP) && >> + (s->op != SVFOP_CURRENT_TIMESTAMP_N) && >> + (s->op != SVFOP_CURRENT_TIME) && >> ... >> >> The above check appears more than once. If extracted into a helper >> method, it would help reduce duplicate and make the code more >> readable. > > Perhaps in a MACRO?
Changed this check to a macro, also fixed condition in is_foreign_param() and added test for it. Also fixed comment in prepare_query_params().
It seems to me that the svf->xpr field ( SQLValueFunction *svf ) is not initialized somewhere even by deparseSQLValueFunction. If it's not really used, it should be initialized to NULL, ok?