Re: Push down time-related SQLValue functions to foreign server

Ranier Vilela писал 2021-08-20 14:19:

> Another question:
> For 0002 patch:
> 
> + if (node->funcid == F_NOW)
> + {
> + SQLValueFunction *svf = makeNode(SQLValueFunction);
> +
> + svf->op = SVFOP_CURRENT_TIMESTAMP;
> + svf->type = TIMESTAMPTZOID;
> + svf->typmod = -1;
> + svf->location = -1;
> +
> + deparseSQLValueFunction(svf, context);
> +
> + return;
> + }
> It seems to me that the svf->xpr field ( SQLValueFunction *svf ) is
> not initialized somewhere even by deparseSQLValueFunction.
> If it's not really used, it should be initialized to NULL, ok?
> 

xpr field just carries node type, which will be initialized by 
makeNode().

-- 
Best regards,
Alexander Pyhalov,
Postgres Professional