> Hi, > src/backend/commands/sequence.c > Has two shadows (buf var), with two unnecessary variables declared.
These are not unnecessary -- removing them breaks translatability of those messages. If these were ssize_t you could use '%zd' (see commit ac4ef637ad2f) but I don't think you can in this case.
Hi Alvaro, thanks for reply.
File backend\utils\sort\tuplesort.c: elog(LOG, "worker %d using " INT64_FORMAT " KB of memory for read buffers among %d input tapes",
File backend\storage\ipc\shm_toc.c: elog(ERROR, "could not find key " UINT64_FORMAT " in shm TOC at %p",
File backend\storage\large_object\inv_api.c: * use errmsg_internal here because we don't want to expose INT64_FORMAT errmsg_internal("invalid large object seek target: " INT64_FORMAT,
elog and errmsg_internal, permits use as proposed by the patch,
does it mean that errmsg, does not allow and does not do the same job as snprintf?