Re: [PATCH] fix two shadow vars (src/backend/commands/sequence.c)

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: [PATCH] fix two shadow vars (src/backend/commands/sequence.c)
Дата
Msg-id 20200611201921.GA29675@alvherre.pgsql
обсуждение исходный текст
Ответ на [PATCH] fix two shadow vars (src/backend/commands/sequence.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Ответы Re: [PATCH] fix two shadow vars (src/backend/commands/sequence.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Список pgsql-hackers
On 2020-Jun-11, Ranier Vilela wrote:

> Hi,
> src/backend/commands/sequence.c
> Has two shadows (buf var), with two unnecessary variables declared.

These are not unnecessary -- removing them breaks translatability of
those messages.  If these were ssize_t you could use '%zd' (see commit
ac4ef637ad2f) but I don't think you can in this case.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: Atomic operations within spinlocks
Следующее
От: Jeff Davis
Дата:
Сообщение: Re: Default setting for enable_hashagg_disk