Re: Missing const in DSA.

Поиск
Список
Период
Сортировка
От Thomas Munro
Тема Re: Missing const in DSA.
Дата
Msg-id CAEepm=3aCRzh35kYJf_2Eq39ALKhUXLzqHcrKFE=DwDQ3Y7FcA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Missing const in DSA.  (Thomas Munro <thomas.munro@enterprisedb.com>)
Список pgsql-hackers
On Tue, Sep 25, 2018 at 7:46 AM Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Tue, Sep 25, 2018 at 4:17 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Thomas Munro <thomas.munro@enterprisedb.com> writes:
> > > On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > >> Mark G <markg735@gmail.com> writes:
> > >>> While looking at some of the recent churn in DSA I noticed that
> > >>> dsa_size_class_map should probably be declared const.
> >
> > >> +1 ... also, given the contents of the array, "char" seems like
> > >> rather a misnomer.  I'd be happier if it were declared as uint8, say.

Pushed.  Thanks both for the code review!

-- 
Thomas Munro
http://www.enterprisedb.com


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Proposal for Signal Detection Refactoring
Следующее
От: Haribabu Kommi
Дата:
Сообщение: Re: Revoke execution permission of pg_stat_statements_reset() frompg_read_all_stats role