Re: Memory leak fix in psql

Поиск
Список
Период
Сортировка
От Junwang Zhao
Тема Re: Memory leak fix in psql
Дата
Msg-id CAEG8a3L5wwEfTJv9t0VMXEuGggOpg4pbTyua3mz2eRdDf5wtnw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Memory leak fix in psql  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Memory leak fix in psql  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
-1

Though the patch looks good, I myself think the patch should be edited
and submitted by Tang
It's easy to attach a fixed patch based on the comments of the thread,
but coins should be
given to Tang since he is the first one to find the mem leak.

No offense, but that's what I think how open source works ;)

On Wed, Jul 20, 2022 at 11:51 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Jul 20, 2022 at 03:14:35AM +0000, tanghy.fnst@fujitsu.com wrote:
> > Your fix LGTM so please allow me to merge it in the attached patch.
> > Based on your rebased version, now this new patch version is V3.
>
> What about the argument of upthread where we could use a goto in
> functions where there are multiple pattern validation checks?  Per se
> v4 attached.
> --
> Michael



-- 
Regards
Junwang Zhao



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Remove fls(), use pg_bitutils.h facilities instead?