Thank you for sharing updated patch. With latest 9.5 source code, patch build is failing with following error message i.e.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C catalog schemapg.h
cd ../../../src/include/catalog && '/opt/local/bin/perl' ./duplicate_oids
3255
make[3]: *** [postgres.bki] Error 1
make[2]: *** [submake-schemapg] Error 2
make[1]: *** [all-backend-recurse] Error 2
make: *** [all-src-recurse] Error 2
New function is being added by following commit i.e.
commit b34e37bfefbed1bf9396dde18f308d8b96fd176c
Author: Robert Haas <rhaas@postgresql.org>
Date: Thu Aug 14 12:09:52 2014 -0400
Add sortsupport routines for text.
This provides a small but worthwhile speedup when sorting text, at least
in cases to which the sortsupport machinery applies.
Robert Haas and Peter Geoghegan
It seems that you need to use another oid. Other than this patch looks good to me, please share updated patch and feel free to assign it to committer. Thanks.
Regards,
Muhammad Asif Naeem