Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch

Поиск
Список
Период
Сортировка
От Soumyadeep Chakraborty
Тема Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch
Дата
Msg-id CAE-ML+9_9EmKQgTzzypiXRk+1+XCm9mDs3o5wa0=8oEVmz_M=w@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch  (Andres Freund <andres@anarazel.de>)
Ответы Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
Hey,

I completely agree, that was an important consideration.

I had some purely cosmetic suggestions:
1. Rename ExecComputeSlotInfo to eliminate the need for the asserts.
2. Extract return value to a bool variable for slightly better
readability.
3. Taking the opportunity to use TTS_IS_VIRTUAL.

v2 of patch set attached. The first two patches are unchanged, the cosmetic
changes are part of v2-0003-Some-minor-cosmetic-changes.patch.

--
Soumyadeep
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: contrib/bloom Valgrind error
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Change atoi to strtol in same place