Re: Hi & some questions regarding Properties & contribution

Hi Dave,

Not sure what legal problems we would run into. PostgreSQL isn't a legal entity. The code is freebsd licensed. Any code contributed inherits the PostgreSQL copyright. 

This article explains it better than I could: http://oss-watch.ac.uk/resources/cla

One example of a problem is: if somebody implements something while employed, and the Employer is not aware of the work, you might have to remove the code again, and it might be trouble for the employee (in an extreme case the whole github account could be closed for some DCMA violation). Another example is, if somebody submits GPL/LGPL code, then it is in violation of the license terms.

For me the specific problem is, I can't put the driver up for reuse with the Eclipse foundation projects as long as there is no contribution policy in place :-/


Jürgen

On 13.04.2014 01:32, Dave Cramer wrote:

Hi Jurgen,

See my comments inline

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca

On 12 April 2014 18:58, Jürgen Rose <cptmauli@googlemail.com> wrote:

Hi Dave,

The code itself is finished, I still have to test it and I'm still waiting on an answer from the OSGi mailinglist how properties should be handled which are not there (ignore or exception).

About the description property, I was just curious. Is there actually an up to date JDBC test suite somewhere? Do you test the driver for conformity somehow?

No, I don't test it. Sun (now Oracle) has one. It is arduous to run. You have to create a file which explains the exceptions to the spec or how you handle the ambiguities. I ran it once when someone paid me to do the work. I haven't run it in a number of years now

 

The Eclipse contribution policy is really strict. You can find details her: http://wiki.eclipse.org/Development_Resources/Contributing_via_Git and here http://www.eclipse.org/projects/dev_process/ip-process-in-cartoons.php

The Apache process is pretty similar: http://www.apache.org/licenses/#clas thats why it is not a problem for Eclipse to add dependencies based on apache projects. To provide a different example - Chef: http://docs.opscode.com/community_contributions.html and some more: http://openmetaverse.org/about-open-metaverse-foundation http://www.overte.org/contribution-agreement.html

It sounds like work, and it is work, and it makes it of course more difficult to participate. But it definitely gives you also some security that you don't run into legal problems.

Not sure what legal problems we would run into. PostgreSQL isn't a legal entity. The code is freebsd licensed. Any code contributed inherits the PostgreSQL copyright. 

Formatting:

I will not begin a formatting binge (-> ugly diffs). I just saw that in some files the formatting was inconsistent in the file itself, hence my question. Funnily enough, your example is exactly the style we use in the Eclipse SCADA project. For the JDBC driver I try to create a formatter which resembles closely the majority of the existing code, I'll add the file as well.

Thanks,

 

I found this in the README.md under "Testing":

You also need to test your changes with older JDKs. PgJDBC must support JDK5 ("Java 1.5") and newer, which means you can't use annotations, auto-boxing, for (:), and numerous other features added since JDK 5. Code that's JDBC4 specific may use JDK6 features, and code that's JDBC4.1 specific may use JDK7 features. Common code and JDBC3 code needs to stick to Java 1.5.

I would say, this paragraph is misleading. If you say PgJDBC must support JDK5, then annotations, enhanced for loops, generics and so on can be used! Only for JDBC2 this is relevant, but its not supported anyway as far as I understand the build. The only thing which one has to be really careful are things which were added after Java 1.5 (e.g. override annotations on interfaces, switch with strings etc).

Yes, it is misleading . Your version is more correct 

best regards
Jürgen

Am 12.04.2014 01:16, schrieb Dave Cramer:

Jurgen,

Implement properties as you see fit. With docs for them as well

There is no specific reason for not having the description property.

What is their contribution policy? Where do I find it?

Formatting the code en-masse will be a problem. If you want to format your new files as per eclipse be my guest.

My basic rule is keep the formatting the same as whatever file you are editing is. Formatting is a religious argument.

If I had my druthers formatting would be have lots of whitespace, and others don't usually agree

ie function( int arg )

{

   if ( something == something )

   { 

     do something

   }

}

as for header information it should have 

Copyright (c) 2004-2014, PostgreSQL Global Development Group */

Feel free to fix headers in any other files you touch.

Thanks!!!

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca

On 11 April 2014 18:00, Jürgen Rose <cptmauli@googlemail.com> wrote:

Hi,

I'm Jürgen, new on this list and I'm currently osgifying the postgresql
jdbc driver (https://github.com/pgjdbc/pgjdbc/issues/71).

I have some questions regarding the conformity to the JDBC spec.

In section 9.4.1 "DataSource Properties" it reads: The only property
required for all DataSource implementations is description

When I look at the implementation, there is no description property. Is
there any specific reason for this?

The spec also defines a number of other (optional) properties, most of
them are not implemented. Wouldn't it be possible to implement at least
some of them (dataSourceName, ...), just to be nice?

I'm also talking with the IP people from the Eclipse foundation, so that
the JDBC driver can be used as a dependency in some of the projects.
This is not possible at the moment since it failed the validation (the
Eclipse foundation is pretty strict). I'm still trying to find out what
the specific problems are, but as far as I understand a contribution
policy is missing (and maybe other things). And actually I didn't find
one when I looked.

Two things more, how to format the source code? It seems to me that the
code is formatted relatively inconsistent. I'd love to have a formatter
for Eclipse.

What about the header information in the files? Some files have none,
some have /* Copyright (c) 2004-2011, PostgreSQL Global Development
Group */. What should I put into my new file?


Jürgen


--
Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-jdbc