On Sat, Nov 27, 2021 at 7:56 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Nov 26, 2021 at 6:00 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > Indeed. Attached an updated patch. Thanks!
> >
>
Thank you for updating the patch!
> I have made a number of changes in the attached patch which includes
> (a) the patch was trying to register multiple array entries for the
> same subscription which doesn't seem to be required, see changes in
> pgstat_vacuum_stat, (b) multiple changes in the test like reduced the
> wal_retrieve_retry_interval to 2s which has reduced the test time to
> half, remove the check related to resetting of stats as there is no
> guarantee that the message will be received by the collector and we
> were not sending it again, changed the test case file name to
> 026_stats as we can add more subscription-related stats in this test
> file itself
Since we have pg_stat_subscription view, how about 026_worker_stats.pl?
The rests look good to me.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/