Re: patch to allow disable of WAL recycling

Поиск
Список
Период
Сортировка
От Jerry Jelinek
Тема Re: patch to allow disable of WAL recycling
Дата
Msg-id CACPQ5FqTeddDX-OURpRtBzBZkfH0ZPMUWx=TCRAZQsbY+7S6rQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: patch to allow disable of WAL recycling  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Ответы Re: patch to allow disable of WAL recycling  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Hi Peter,

I'll take a look at that. I had been trying to keep the patch as minimal as possible, but I'm happy to work through this.

Thanks,
Jerry


On Tue, Sep 11, 2018 at 9:39 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
On 10/09/2018 16:10, Jerry Jelinek wrote:
> Thank you again for running all of these tests on your various hardware
> configurations. I was not aware of the convention that the commented
> example in the config file is expected to match the default value, so I
> was actually trying to show what to use if you didn't want the default,
> but I am happy to update the patch so the comment matches the default.
> Beyond that, I am unsure what the next steps are for this proposal.

Could you organize the code so that the block below

    /*
     * Initialize info about where to try to recycle to.
     */

isn't executed if recycling is off, since we don't need it.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alexander Kuzmenkov
Дата:
Сообщение: Re: Index Skip Scan
Следующее
От: Tom Lane
Дата:
Сообщение: Re: pg_dump test instability