On Tue, Jan 5, 2021 at 6:55 PM Stephen Frost <sfrost@snowman.net> wrote:
>
> * Stephen Frost (sfrost@snowman.net) wrote:
> > Moderation notices for things like news posts is currently coming from
> > webmaster@, which is a mailing list and something we generally would
> > prefer that we not be sending emails from, and responses to those
> > moderation notices end up going to webmaster@ which isn't actually the
> > right address.
> >
> > Attached is a patch which changes the From to be a noreply address
> > (NEWS_MAIL_SENDER specifically, which is announce-noreply in this case,
> > and as this is related to posts to announce that seems alright), and
> > adds a ReplyTo which is the NOTIFICATION_EMAIL address where
> > notifications should go (which is the pgweb moderator's mailing list,
> > where the moderators who are trying to moderate news postings are
> > subscribed).
> >
> > Thoughts?
>
> ... attached.
I think using NEWS_MAIL_SENDER is the wrong thing to do, since this is
what's sent for *all* objects, not just news.. E.g. events,
organisations, products, etc.
Either we need a more generic sender (maybe MODERATION_MAIL_SENDER or
something?), or we need to implement it independently for each type of
moderated object (which seems, excessive?)
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/