Re: Feature request: Logging SSL connections

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: Feature request: Logging SSL connections
Дата
Msg-id CABUevEyYqigS9bjv2JTKLn=mhzgs4bL=j2vvxxzYZ_mJ2WBMaw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Feature request: Logging SSL connections  (Marko Kreen <markokr@gmail.com>)
Ответы Re: Feature request: Logging SSL connections  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Дерево обсуждения
On Sun, Dec 8, 2013 at 10:27 AM, Marko Kreen <markokr@gmail.com> wrote:
On Fri, Dec 06, 2013 at 02:53:27PM +0100, Dr. Andreas Kunert wrote:
> >>Anything else missing?
> >
> >Functionally it's fine now, but I see few style problems:
> >
> >- "if (port->ssl > 0)" is wrong, ->ssl is pointer.  So use just
> >   "if (port->ssl)".
> >- Deeper indentation would look nicer with braces.
> >- There are some duplicated message, could you restructure it so that
> >   each message exists only once.
>
> New version is attached. I could add braces before and after the
> ereport()-calls too, but then I need two more #ifdefs to catch the
> closing braces.

Thank you.  Looks good now.  I added it to next commitfest:

  https://commitfest.postgresql.org/action/patch_view?id=1324



Applied, thanks! 

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: Re: [PATCH] Fix double-inclusion of pg_config_os.h when building extensions with Visual Studio
Следующее
От: Pavel Stehule
Дата:
Сообщение: Re: patch: option --if-exists for pg_dump