Re: [PATCH] Fix double-inclusion of pg_config_os.h when building extensions with Visual Studio

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: [PATCH] Fix double-inclusion of pg_config_os.h when building extensions with Visual Studio
Дата
Msg-id CABUevEz4pkgrMAzUygXZ-FXD+ytogNkU-qMjOQTo4oj=ndB2_A@mail.gmail.com
обсуждение исходный текст
Ответ на [PATCH] Fix double-inclusion of pg_config_os.h when building extensions with Visual Studio  (Craig Ringer <craig@2ndquadrant.com>)
Ответы Re: [PATCH] Fix double-inclusion of pg_config_os.h when building extensions with Visual Studio  (Craig Ringer <craig@2ndquadrant.com>)
Список pgsql-hackers
On Sat, Jan 11, 2014 at 8:57 AM, Craig Ringer <craig@2ndquadrant.com> wrote:
Hi all

Related to the earlier comments about building extensions on Windows, I
just noticed that we don't treat "WINDLL" as equivalent to "WIN32", and
"WIN32" isn't set in a Visual Studio DLL project.

We should actually be testing _WIN32, which is the compiler's
pre-defined macro. The attached patch to c.h takes care of that - it
tests _WIN32 in c.h and sets WIN32 early if it's found.

_WIN32 is set for both win32 and win64, like we expect from WIN32.

Regardless of where the other thread goes, this seems like something we should fix. Thus - applied, with minor changes to the comment, thanks.

My understanding is that this change alone doesn't actually help us very much, so I haven't backpatched it anywhere. Let me know if that understanding was incorrect, and it would actually help as a backpatch.


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Emre Hasegeli
Дата:
Сообщение: Re: [PATCH] pgcrypto: implement gen_random_uuid
Следующее
От: Magnus Hagander
Дата:
Сообщение: Re: Feature request: Logging SSL connections