Re: pg_dump -j against standbys

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: pg_dump -j against standbys
Дата
Msg-id CABUevExRKMUKrJg=CdU6xaAfppZwE3kJjfm+R8XS4LsMD9GkSg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: pg_dump -j against standbys  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: pg_dump -j against standbys  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Wed, May 25, 2016 at 4:21 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Magnus Hagander <magnus@hagander.net> writes:
>> Also, why didn't you keep using ExecuteSqlQueryForSingleRow()?

> The reason I did that is that ExecuteSqlQueryForSingleRow() is a static
> method in pg_dump.c. I was planning to go back and review that, and
> consider moving it, but I forgot it :S

> I think the clean thing is probably to use that one, and also move it over
> to not be a static method in pg_dump.c, but instead sit next to
> ExecuteSqlQuery in pg_backup_db.c. Do you agree that's reasonable, and
> something that's OK to backpatch?

No objection here, since it wouldn't be exposed outside pg_dump in any
case.

Here's an updated patch based on this,and the other feedback. 


--
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Dean Rasheed
Дата:
Сообщение: Re: RLS related docs
Следующее
От: Kyotaro HORIGUCHI
Дата:
Сообщение: Fix a failure of pg_dump with !HAVE_LIBZ