On Wed, May 25, 2016 at 4:21 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Magnus Hagander <magnus@hagander.net> writes: >> Also, why didn't you keep using ExecuteSqlQueryForSingleRow()?
> The reason I did that is that ExecuteSqlQueryForSingleRow() is a static > method in pg_dump.c. I was planning to go back and review that, and > consider moving it, but I forgot it :S
> I think the clean thing is probably to use that one, and also move it over > to not be a static method in pg_dump.c, but instead sit next to > ExecuteSqlQuery in pg_backup_db.c. Do you agree that's reasonable, and > something that's OK to backpatch?
No objection here, since it wouldn't be exposed outside pg_dump in any case.
Here's an updated patch based on this,and the other feedback.