Re: pg_dump -j against standbys
| От | Tom Lane |
|---|---|
| Тема | Re: pg_dump -j against standbys |
| Дата | |
| Msg-id | 24912.1464186090@sss.pgh.pa.us обсуждение |
| Ответ на | Re: pg_dump -j against standbys (Magnus Hagander <magnus@hagander.net>) |
| Ответы |
Re: pg_dump -j against standbys
|
| Список | pgsql-hackers |
Magnus Hagander <magnus@hagander.net> writes:
>> Also, why didn't you keep using ExecuteSqlQueryForSingleRow()?
> The reason I did that is that ExecuteSqlQueryForSingleRow() is a static
> method in pg_dump.c. I was planning to go back and review that, and
> consider moving it, but I forgot it :S
> I think the clean thing is probably to use that one, and also move it over
> to not be a static method in pg_dump.c, but instead sit next to
> ExecuteSqlQuery in pg_backup_db.c. Do you agree that's reasonable, and
> something that's OK to backpatch?
No objection here, since it wouldn't be exposed outside pg_dump in any
case.
regards, tom lane
В списке pgsql-hackers по дате отправления: