Re: [HACKERS] Timing-sensitive case in src/test/recovery TAP tests

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [HACKERS] Timing-sensitive case in src/test/recovery TAP tests
Дата
Msg-id CAB7nPqTuFCTyDJCNpYZ-MtHhBasjYOzDYkHcn9S1PQBc5MdHtw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] Timing-sensitive case in src/test/recovery TAP tests  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [HACKERS] Timing-sensitive case in src/test/recovery TAP tests  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Tue, Jun 27, 2017 at 3:44 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Looks good as far as it goes, but I wonder whether any of the other
> get_slot_xmins calls need polling too.  Don't feel a need to add such
> calls until someone exhibits a failure there, but I won't be very
> surprised if someone does.

I got the same thought, wondering as well if get_slot_xmins should be
renamed check_slot_xmins with the is() tests moved inside it as well.
Not sure if that's worth the API ugliness though.

> Anyway, pushed this patch with minor editing.  Thanks!

Thanks.
-- 
Michael



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] Reducing pg_ctl's reaction time
Следующее
От: Thomas Munro
Дата:
Сообщение: Re: [HACKERS] Causal reads take II