On Fri, Apr 4, 2014 at 9:44 PM, Andres Freund <andres@2ndquadrant.com> wrote:
>> I imagine
>> that if we want to guarantee the correctness of a replication slot we
>> would need to fetch from archives the necessary WAL files needed for
>> it when a node is in recovery, which is not something that this patch
>> does...
>
> Does that mean you "retract" the patch?
For 9.4, clearly yes, this would change the semantic of recovery and
this is not something wise to do at the end of a development cycle.
For 9.5 though, this is a different story. It clearly depends on if
this is though as useful enough to change how recovery fetches WAL
files (in this case by scanning existing repslots). There are other
things to consider as well like for example: do we reset the
restart_lsn of a repslot if needed WAL files are not here anymore or
abort recovery? I haven't worked much with repslots though...
--
Michael