Re: Unused macros in src/include/access/transam.h

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Unused macros in src/include/access/transam.h
Дата
Msg-id CAB7nPqTMFq9Kao_9vGr_dshkUZb+CwjMOr_SA3uhDvrqRh4BQw@mail.gmail.com
обсуждение исходный текст
Ответ на Unused macros in src/include/access/transam.h  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
Список pgsql-hackers
On Wed, Apr 6, 2016 at 4:55 AM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
> Hi all,
>
> When dealing with some patch review I've noticed there are two macro is not
> used anywhere:
>
> #define TransactionIdStore(xid, dest)   (*(dest) = (xid))
> #define StoreInvalidTransactionId(dest) (*(dest) = InvalidTransactionId)

Not by the core code, perhaps they are used by extensions though. The
last bit of code using TransactionIdStore is from 2007 (282d2a03), by
the way. Still, knowing the low level of maintenance those are
requiring, it does not seem worth a compilation breakage I think.
--
Michael



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Thomas Munro
Дата:
Сообщение: Re: Proposal: "Causal reads" mode for load balancing reads without stale data
Следующее
От: David Fetter
Дата:
Сообщение: Re: Materialized views vs. primary keys