Re: Header and comments describing routines in incorrect shape in visibilitymap.c

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Header and comments describing routines in incorrect shape in visibilitymap.c
Дата
Msg-id CAB7nPqQFQk9KVv-wzkAy6WN4RBica5kh9JfnuxahHNf-cFvTrg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Header and comments describing routines in incorrect shape in visibilitymap.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Header and comments describing routines in incorrect shape in visibilitymap.c  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-hackers
On Fri, Jul 8, 2016 at 1:18 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> Regarding the first hunk, I don't like these INTERFACE sections too
>> much; they get seriously outdated over the time and aren't all that
>> helpful anyway.  See the one on heapam.c for example.  I'd rather get
>> rid of that one instead of patching it.  The rest, of course, merit
>> revision.
>
> +1, as long as we make sure that any useful info therein gets migrated
> to the per-function header comments rather than dropped.  If there's
> anything that doesn't seem to fit naturally in any per-function comment,
> maybe move it into the file header comment?

OK, that removes comment duplication. Also, what about replacing
"bit(s)" by "one or more bits" in the comment terms where adapted?
That's bikeshedding, but that's what this patch is about.
-- 
Michael



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Simon Riggs
Дата:
Сообщение: Re: A Modest Upgrade Proposal
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: pg_xlogfile_name_offset() et al and recovery