Re: Add palloc_aligned() to allow arbitrary power of 2 memory alignment

Поиск
Список
Период
Сортировка
От David Rowley
Тема Re: Add palloc_aligned() to allow arbitrary power of 2 memory alignment
Дата
Msg-id CAApHDvqZNwLeKPNxyLi6avGmHLaJr38XsA+LS5UdrcNDgo+Z8Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Add palloc_aligned() to allow arbitrary power of 2 memory alignment  (Andres Freund <andres@anarazel.de>)
Ответы Re: Add palloc_aligned() to allow arbitrary power of 2 memory alignment
Список pgsql-hackers
On Tue, 15 Nov 2022 at 11:11, Andres Freund <andres@anarazel.de> wrote:
> Couldn't we reduce the amount of over-allocation by a small amount by special
> casing the already-aligned case? That's not going to be relevant for page size
> aligne allocations, but for smaller alignment values it could matter.

I don't quite follow this. How can we know the allocation is already
aligned without performing the allocation? To perform the allocation
we must tell palloc what size to allocate. So, we've already wasted
the space by the time we can tell if the allocation is aligned to what
we need.

Aside from that, there's already a special case for alignto <=
MAXIMUM_ALIGNOF.  But we know no palloc will ever return anything
aligned less than that in all cases, which is why that can work.

David



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: Non-decimal integer literals
Следующее
От: Daniel Gustafsson
Дата:
Сообщение: Re: Unit tests for SLRU