Re: Unit tests for SLRU

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: Unit tests for SLRU
Дата
Msg-id 65EFC7A1-B9C5-42F5-9ADA-D88792AB9340@yesql.se
обсуждение исходный текст
Ответ на Re: Unit tests for SLRU  (Aleksander Alekseev <aleksander@timescale.com>)
Ответы Re: Unit tests for SLRU  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Дерево обсуждения 
> On 15 Nov 2022, at 11:15, Aleksander Alekseev <aleksander@timescale.com> wrote:

>> What do you think?
>
> It looks much better than before. I replaced strcpy() with strncpy()
> and pgindent'ed the code.

+    /* write given data to the page */
+    strncpy(TestSlruCtl->shared->page_buffer[slotno], data, BLCKSZ - 1);

Would it make sense to instead use pg_pwrite to closer match the code being
tested?

> Other than that to me it looks ready to be committed.

Agreed, reading over it nothing sticks out.

--
Daniel Gustafsson        https://vmware.com/

В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: Add palloc_aligned() to allow arbitrary power of 2 memory alignment
Следующее
От: Bharath Rupireddy
Дата:
Сообщение: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL