Re: Use uppercase keywords in foreign key tutorial
| От | David Rowley |
|---|---|
| Тема | Re: Use uppercase keywords in foreign key tutorial |
| Дата | |
| Msg-id | CAApHDvqR+_EU0mxrmS-AieE_8ovqtmnsJSOk-oq-Rdk3JzNWOg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Use uppercase keywords in foreign key tutorial (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: Use uppercase keywords in foreign key tutorial
Re: Use uppercase keywords in foreign key tutorial |
| Список | pgsql-docs |
On Thu, 30 Oct 2025 at 09:48, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Bruce Momjian <bruce@momjian.us> writes: > > On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote: > >> I noticed the patch also changes some column types to lowercase: > >> ... > >> - category_N TEXT > >> + category_N text > >> > >> FWIW I tend to use uppercase for those, too, but I'm not sure there is a > >> preferred style for the docs. > > > Agreed, uppercase is better for type names. > > "text" is not a keyword according to either us or the SQL standard. > I agree that there's some reason to capitalize things that are > grammar keywords, such as INTEGER or VARCHAR, but it's a big stretch > to go from that to capitalizing everything that is a type name. > Would you capitalize user-defined type names? Going by: git grep -i "\btext\b," we're fairly consistently using lower case, so FWIW, when I looked, I thought Eric's change made sense. How about if Eric just drops the portion of the patch that alters the casing of the types and leaves all the keyword uppercasing stuff in. Any objections to that part? David
В списке pgsql-docs по дате отправления: