On Thu, 3 Jun 2021 at 16:17, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > There are quite a few other places in that file that should be using
> > DatumGetCString() instead of DatumGetPointer().
> > Should we fix those too for PG14?
>
> +1. I'm surprised we are not getting compiler warnings.
I've attached a patch to fix those.
I did end up getting in a little deeper than I'd have liked as I also
found a few typos along the way.
Also, going by my calendar, the copyright year was incorrect.
Tomas, any chance you could look over this? I didn't really take the
time to understand the code, so some of my comment adjustments might
be incorrect.
David