On Mon, Dec 17, 2018 at 1:04 PM Michael Paquier <
michael@paquier.xyz> wrote:
>
> On Mon, Dec 17, 2018 at 12:49:03PM +0530, amul sul wrote:
> > On Mon, Dec 17, 2018 at 11:54 AM Michael Paquier <
michael@paquier.xyz> wrote:
> >> So this settles the argument that we had better not do anything before
> >> v11. Switching the dump code to use column numbers has not proved to be
> >> complicated as only the query and some comments had to be tweaked.
> >> Attached is an updated patch, and I am switching back the patch to
> >> "Needs review" to have an extra pair of eyes look at that in case I
> >> missed something.
> >
> > This v4-patch needs a rebase against the latest master head(#67915fb).
>
> I am on top of the master branch at 67915fb8, and this applies fine for
> me:
> $ patch -p1 < dump-alter-index-stats-v4.patch
> patching file src/bin/pg_dump/pg_dump.c
> patching file src/bin/pg_dump/pg_dump.h
> patching file src/bin/pg_dump/t/
002_pg_dump.pl>
Thanks, patch command works for me as well, with git I was getting a following failure:
Laptop215:PG edb$ git apply ~/Downloads/dump-alter-index-stats-v4.patch
/Users/edb/Downloads/dump-alter-index-stats-v4.patch:10: trailing whitespace.
i_indreloptions,
/Users/edb/Downloads/dump-alter-index-stats-v4.patch:11: trailing whitespace.
i_indstatcols,
/Users/edb/Downloads/dump-alter-index-stats-v4.patch:12: trailing whitespace.
i_indstatvals;
/Users/edb/Downloads/dump-alter-index-stats-v4.patch:21: trailing whitespace.
"t.reloptions AS indreloptions, "
/Users/edb/Downloads/dump-alter-index-stats-v4.patch:22: trailing whitespace.
"(SELECT pg_catalog.array_agg(attnum ORDER BY attnum) "
error: patch failed: src/bin/pg_dump/pg_dump.c:6712
error: src/bin/pg_dump/pg_dump.c: patch does not apply
error: patch failed: src/bin/pg_dump/pg_dump.h:360
error: src/bin/pg_dump/pg_dump.h: patch does not apply
error: patch failed: src/bin/pg_dump/t/002_pg_dump.pl:2343
error: src/bin/pg_dump/t/002_pg_dump.pl: patch does not apply
Laptop215:PG edb$ git --version
git version 2.14.1
Regards,
Amul