On Mon, Jan 08, 2024 at 11:13:42AM +0530, Amul Sul wrote: > +void * > +dsm_registry_init_or_attach(const char *key, size_t size, > > I think the name could be simple as dsm_registry_init() like we use > elsewhere e.g. ShmemInitHash() which doesn't say attach explicitly.
That seems reasonable to me.
> Similarly, I think dshash_find_or_insert() can be as simple as > dshash_search() and > accept HASHACTION like hash_search().
I'm not totally sure what you mean here. If you mean changing the dshash API, I'd argue that's a topic for another thread.
Yes, you are correct. I didn't realize that existing code -- now sure, why wouldn't we implemented as the dynahash. Sorry for the noise.