On Thu, Nov 25, 2021 at 1:30 PM Amit Langote <amitlangote09@gmail.com> wrote:
>
> On Wed, Nov 24, 2021 at 5:44 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > On Wed, Nov 24, 2021 at 12:02 PM Amit Langote <amitlangote09@gmail.com> wrote:
> > > So yeah, documenting the ATTACH issue as a limitation sounds like the
> > > best course for now. I might word it as follows and add it under
> > > Notes at https://www.postgresql.org/docs/current/sql-createpublication.html:
> > >
> > > "ATTACHing a table into a partition tree whose root is published using
> > > a publication with publish_via_partition_root set to true does not
> > > result in the table's existing contents to be replicated."
> >
> > Instead of "to be", shall we use "being"?
>
> That reads better.
>
> > > I'm not sure there's a clean enough workaround to this that we can add
> > > to the paragraph.
> > >
>
> I agree with backpatching the doc fix. I've attached a diff against
> master, though it also appears to apply to 13 and 14 branches.
>
I think we can <literal></literal> for publish_via_partition_root,
other than that the patch looks good to me.
Hou-San, others, do you have any opinion about this patch and whether
to backpatch it or not?
--
With Regards,
Amit Kapila.