Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

On Wed, Jul 15, 2020 at 4:51 PM Ajin Cherian <itsajin@gmail.com> wrote:
>
> On Wed, Jul 15, 2020 at 2:05 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>>
>>   Please see the
>> latest patch set v33.
>>
>>
>>
>
> I have a minor comment. You've defined a new function ReorderBufferStartStreaming() but the function doesn't actually
startstreaming but is used to find out if you can start streaming and it returns a boolean. Can't you name it
accordingly?
> Probably ReorderBufferCanStartStreaming(). I understand that it internally calls ReorderBufferCanStream() which is
similarsounding but I think that should not matter.
 
>

+1.  I am actually editing some of the patches and I have already
named it as you are suggesting.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com