On Mon, Sep 10, 2018 at 3:54 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>
> >> Hello Bradley & Tatsuo-san,
> >>
> >>>> ... references to the protocol version lacks homogeneity.
> >>>> ... I'd suggest to keep "the vX.0 protocol" for a short version,
> >>>> and "the version X.0 protocol" for long ...
> >>>
> >>> I agree. Change made.
> >>
> >> Patch applies cleanly. Doc build ok.
> >>
> >> One part talks about "terminating line", the other of "termination
> >> line". I wonder whether one is better than the other?
> >
> > I am not a native English speaker so I maybe wrong... for me, current
> > usage of "terminating line", and "termination line" looks correct. The
> > former refers to concrete example thus uses "the", while the latter
> > refers to more general case thus uses "an".
> >
> > BTW, I think the patch should apply to master and REL_11_STABLE
> > branches at least. But should this be applied to other back branches
> > as well?
>
> I have marked this as "ready for committer".
>
My first thought on this patch is that why do we want to duplicate the
same information in different words at three different places. Why
can't we just extend the current Note where it is currently with some
more information about CopyDone message and then add a reference to
that section in other two places?
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com