On Wed, Oct 7, 2020 at 11:24 AM Masahiko Sawada
<masahiko.sawada@2ndquadrant.com> wrote:
>
> On Tue, 6 Oct 2020 at 17:56, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Tue, Oct 6, 2020 at 9:34 AM Masahiko Sawada
> > <masahiko.sawada@2ndquadrant.com> wrote:
> > >
> > > Looking at pgstat_reset_replslot_counter() in the v8 patch, even if we
> > > pass a physical slot name to pg_stat_reset_replication_slot() a
> > > PgStat_MsgResetreplslotcounter is sent to the stats collector. I’m
> > > okay with not raising an error but maybe we can have it not to send
> > > the message in that case.
> > >
> >
> > makes sense, so changed accordingly.
> >
>
> Thank you for updating the patch!
>
Thanks, I will push the first one tomorrow unless I see more comments
and test-case one later. I think after we are done with this the next
step would be to finish the streaming stats work [1]. We probably need
to review and add the test case in that patch. If nobody else shows up
I will pick it up and complete it.
[1] - https://www.postgresql.org/message-id/CAFPTHDZ8RnOovefzB%2BOMoRxLSD404WRLqWBUHe6bWqM5ew1bNA%40mail.gmail.com
--
With Regards,
Amit Kapila.