Re: WAL usage calculation patch

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: WAL usage calculation patch
Дата
Msg-id CAA4eK1J-93etuAgUr2hUz6gbiozuxOXoRGOS-zeNsF166-vTbg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: WAL usage calculation patch  (Julien Rouhaud <rjuju123@gmail.com>)
Ответы Re: WAL usage calculation patch  (Julien Rouhaud <rjuju123@gmail.com>)
Список pgsql-hackers
On Thu, Apr 30, 2020 at 2:19 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
>
> Here's the patch.  I included the content of
> v3-fix_explain_wal_output.patch you provided before, and tried to
> consistently replace full page writes/fpw to full page images/fpi
> everywhere on top of it (so documentation, command output, variable
> names and comments).
>

Your patch looks mostly good to me.  I have made slight modifications
which include changing the non-text format in show_wal_usage to use a
capital letter for the second word, which makes it similar to Buffer
usage stats, and additionally, ran pgindent.

Let me know what do you think of attached?

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Should program exit, When close() failed for O_RDONLY mode
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Rotten parts of src/backend/replication/README