Re: Problem while setting the fpw with SIGHUP

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: Problem while setting the fpw with SIGHUP
Дата
Msg-id CAA4eK1+_=2HUWQkhG1UGcPva08GQ6MoF5PGWwrdOnY1aSEKuhw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Problem while setting the fpw with SIGHUP  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Problem while setting the fpw with SIGHUP  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Thu, Sep 27, 2018 at 6:22 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Sep 27, 2018 at 04:19:02PM +0530, Amit Kapila wrote:
> > I think this is mostly fine, but it seems "if the instance just got
> > out of recovery" doesn't fit well because it can happen anytime after
> > recovery, this code gets called from checkpointer.  I think we can
> > slightly tweak it as below:
> > "Perform this outside critical section so that the WAL insert
> > initialization done by RecoveryInProgress() doesn't trigger an
> > assertion failure."
> >
> > What do you say?
>
> Fine for me.
>

Okay, I am planning to commit the attached patch tomorrow unless you
or anybody else has any objections to it.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jesper Pedersen
Дата:
Сообщение: Re: pread() and pwrite()
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Let's stop with the retail rebuilds of src/port/ files already